From 82908257a64d4fd67785c76ab33b0392bc9d9724 Mon Sep 17 00:00:00 2001 From: Nick White Date: Mon, 17 Oct 2011 18:39:13 +0100 Subject: Take care to initialise variables before use --- getgbook.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'getgbook.c') diff --git a/getgbook.c b/getgbook.c index a06573e..846dfe7 100644 --- a/getgbook.c +++ b/getgbook.c @@ -71,7 +71,7 @@ int getpagelist() int getpageurls(char *pagecode, char *cookie) { char url[URLMAX], code[STRMAX], m[STRMAX]; - char *c, *d, *p, *q, *buf = NULL; + char *c = NULL, *d, *p, *q, *buf = NULL; int i, j; snprintf(url, URLMAX, "/books?id=%s&pg=%s&jscmd=click3&q=subject:a", bookid, pagecode); @@ -162,6 +162,7 @@ int main(int argc, char *argv[]) char in[16]; int a, i, n; FILE *f; + DIR *d; if(argc < 2 || argc > 3 || (argc == 3 && (argv[1][0]!='-' || (argv[1][1] != 'c' && argv[1][1] != 'n'))) @@ -185,10 +186,11 @@ int main(int argc, char *argv[]) return 1; } - if(!(opendir(bookdir) || !mkdir(bookdir, S_IRWXU))) { + if(!((d = opendir(bookdir)) || !mkdir(bookdir, S_IRWXU))) { fprintf(stderr, "Could not create directory %s\n", bookdir); return 1; } + if(d) closedir(d); if(argc == 2) { for(i=0; i